FIX: PL011 UART driver's configuration for RPi4 #181
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ElectroQuanta
commented
Oct 10, 2024
ElectroQuanta
commented
- Page alignment is required for Bao; all RPi4's UARTs (except for UART0) are not page aligned, thus requiring an offset. This must be defined by the platform's user (plat/platform.h).
- UART_CLK must be overridable and defined by the platform's user (plat/platform.h): in RPi4 PL011 run at 48 MHz
ElectroQuanta
force-pushed
the
fix/pl011-rpi4
branch
from
fc1c692 to
d7010d0
Compare
- Page alignment is required for Bao; all UARTs except for UART0 in the RPi4 are not page aligned, thus requiring an offset. This must be defined by the platform's user (plat/platform.h). - UART_CLK must be overridable and defined by the platform's user (plat/platform.h): in RPi4 PL011 run at 48 MHz Signed-off-by: ElectroQuanta <[email protected]> CI validated
ElectroQuanta
force-pushed
the
fix/pl011-rpi4
branch
from
b76daa4 to
6a0834e
Compare
|
This PRs solves one annoying issue with some platforms' UART not being page aligned. However I don't think this is a very clean solution. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.